Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc warnings in xilem_core, xilem_web #478

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix doc warnings in xilem_core, xilem_web #478

merged 1 commit into from
Aug 2, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

DJMcNab
DJMcNab approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we automate this being checked?

That is, how did you determine these errors?

It's ok to add lints to lib.rs if they are crate specific, so long as we document that in the root Cargo.toml

@waywardmonkeys
Copy link
Contributor Author

Sure, we do in every other repo. This is blocked by #449 in theory, but I've decided to take a different approach to this today once this PR another lands.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Aug 2, 2024
Merged via the queue into linebender:main with commit dd938d4 Aug 2, 2024
16 checks passed
@waywardmonkeys waywardmonkeys deleted the fix-doc-issues-in-xilem branch August 2, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @DJMcNab @jaredoconnell